New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-446] Small bugs fix that do not affect the main logics #1035

Closed

dockerzhang opened this issue Jul 28, 2021 · 0 comments

Milestone

Contributor

dockerzhang commented Jul 28, 2021

Found some small bugs
1. AddressUtils.getIPV4LocalAddress() should first check whether localIPAddress has been set, and use it directly under the premise that it has been set to reduce unnecessary get operations, locate: https://github.com/apache/incubator-tubemq/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/AddressUtils.java#L146

2. The fetchCount parameter in MessageConsumerExample may be negative, so the executorService object should not use fetchCount as the initial value, locate:https://github.com/apache/incubator-tubemq/blob/master/tubemq-example/src/main/java/org/apache/tubemq/example/MessageConsumerExample.java#L99

3. Remove the useless parameter WITHOUTDELAY:

JIRA link - [INLONG-446] created by gosonzhang

dockerzhang added the pull-request-available label

dockerzhang added this to the 0.8.0 milestone

dockerzhang closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment