Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java.util.ConcurrentModificationException error when rebalance #1470

Closed
gosonzhang opened this issue Aug 24, 2021 · 1 comment · Fixed by #1471
Closed

Java.util.ConcurrentModificationException error when rebalance #1470

gosonzhang opened this issue Aug 24, 2021 · 1 comment · Fixed by #1471
Assignees
Labels
Milestone

Comments

@gosonzhang
Copy link
Contributor

When there are many consumer groups in the cluster and frequent load balancing, the Master will report the following error:
image

which is caused by the modification of the subGroups object in the balanceCluster:
image
https://github.com/apache/incubator-inlong/blob/master/inlong-tubemq/tubemq-server/src/main/java/org/apache/inlong/tubemq/server/master/balance/DefaultLoadBalancer.java#L209

we need to fix the bug

@gosonzhang
Copy link
Contributor Author

Optimization items:

  1. Modify the usage mode of the subGroups object to be read-only processing;
  2. Adjust the log printing to output the set of consumer groups affected by each abnormality;
  3. Modify the consumption information acquisition of the consumer group, and add the check that the result is null;
  4. When optimizing the processing of consumer events, the list is changed from judging the size to judging whether it is empty

@gosonzhang gosonzhang added the type/bug Something is wrong label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant