Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] summit job failed after enabling Prometheus #2094

Closed
2 tasks done
dockerzhang opened this issue Jan 4, 2022 · 2 comments · Fixed by #2095
Closed
2 tasks done

[Bug] summit job failed after enabling Prometheus #2094

dockerzhang opened this issue Jan 4, 2022 · 2 comments · Fixed by #2095
Labels
type/bug Something is wrong
Milestone

Comments

@dockerzhang
Copy link
Contributor

What happened

cbf14802c0141c12677e0bebba81e4b

What you expected to happen

summit job successfully after enabling Prometheus

How to reproduce

enable agent.prometheus.enable and summit a job.

Environment

No response

InLong version

master

InLong Component

InLong Agent, Other for not specified component

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@dockerzhang dockerzhang added the type/bug Something is wrong label Jan 4, 2022
@dockerzhang
Copy link
Contributor Author

@shink PTAL

@shink
Copy link
Member

shink commented Jan 4, 2022

It seems that this is because these metrics belong to instances rather than classes, so they will be registered repeatedly when creating multiple instances. A simple solution is to make these metrics static.

https://github.com/apache/incubator-inlong/blob/ea29797d36526f735fd7e7e4fa506430b4e79b1e/inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/metrics/SourcePrometheusMetrics.java#L31-L39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is wrong
Projects
None yet
2 participants