Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Dashboard] Some code specification issues #2799

Closed
1 of 2 tasks
leezng opened this issue Mar 1, 2022 · 0 comments · Fixed by #2800
Closed
1 of 2 tasks

[Bug][Dashboard] Some code specification issues #2799

leezng opened this issue Mar 1, 2022 · 0 comments · Fixed by #2800
Assignees
@leezng
Labels
component/dashboard type/bug Something is wrong
Milestone
1.1.0

Comments

@leezng
Copy link
Member

leezng commented Mar 1, 2022

What happened

https://github.com/apache/incubator-inlong/blob/265f129e0bcd26ffe92322876089293f86a44610/inlong-dashboard/src/utils/requestConcurrentMiddleware.ts#L48

options may be undefined?

What you expected to happen

enhance robustness

How to reproduce

just the link

Environment

No response

InLong version

master

InLong Component

InLong Dashboard

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
@leezng leezng added the type/bug Something is wrong label Mar 1, 2022
@leezng leezng mentioned this issue Mar 1, 2022
Merged
@dockerzhang dockerzhang added this to the 1.1.0 milestone Mar 1, 2022
@healchow healchow changed the title [Bug][dashboard] Some code specification issues [Bug][Dashboard] Some code specification issues Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leezng leezng

Labels
component/dashboard type/bug Something is wrong
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

[INLONG-2799][Dashboard] Enhance code robustness
3 participants
@leezng @dockerzhang @healchow