Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-74] minor updates for DefaultBdbStoreService #673

Closed
dockerzhang opened this issue Jul 28, 2021 · 0 comments
Closed

[INLONG-74] minor updates for DefaultBdbStoreService #673

dockerzhang opened this issue Jul 28, 2021 · 0 comments

Comments

@dockerzhang
Copy link
Contributor

1. fix typo
BDB_TOPIC_AUTHCONTROL_STORE_NAME -> BDB_TOPIC_AUTH_CONTROL_STORE_NAME
tmpbdbEntity -> tmpBdbEntity
2. HelperNode is dynamic :

Set helpers = new HashSet();
InetSocketAddress helper1 = new InetSocketAddress(this.nodeHost, 9005);
InetSocketAddress helper2 = new InetSocketAddress(this.nodeHost, 9006);
InetSocketAddress helper3 = new InetSocketAddress(this.nodeHost, 9007);
helpers.add(helper1);
helpers.add(helper2);
helpers.add(helper3);

to

for(int i = 1; i <= 3; i++){
    InetSocketAddress helper = new InetSocketAddress(this.nodeHost, bdbConfig.getBdbNodePort() + i);
    helpers.add(helper);
}

3. add volatile
change

 private boolean isMaster;

to

private volatile boolean isMaster;

4. remove isStopped and param of getEnvironment

JIRA link - [INLONG-74] created by technoboy

@dockerzhang dockerzhang added this to the 0.5.0 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant