Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-213] Optimize code & Minor changes #812

Closed
dockerzhang opened this issue Jul 28, 2021 · 0 comments
Closed

[INLONG-213] Optimize code & Minor changes #812

dockerzhang opened this issue Jul 28, 2021 · 0 comments

Comments

@dockerzhang
Copy link
Contributor

Optimize code

List messageList = new ArrayList<>();
if (transferedMessageList == null || transferedMessageList.isEmpty()) {
      return messageList;
}

change to

if (transferedMessageList == null || transferedMessageList.isEmpty()) {
return new ArrayList<>();
}
List messageList = new ArrayList<>(transferedMessageList.size());

for (int i; i < 0; i++) {}

change to

for (Object o; objects) {}

String.valueOf(consumerGroup).trim();

change to

consumerGroup.trim();

etc..

JIRA link - [INLONG-213] created by viviel
@dockerzhang dockerzhang added this to the 0.5.0 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant