Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-738][Manager] Supports paging query for workflow execution log #1697

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

healchow
Copy link
Member

@healchow healchow commented Oct 20, 2021

Title Name: [INLONG-738][Manager] Supports paging query for workflow execution log

where XYZ should be replaced by the actual issue number.

Fixes #1327

Motivation

Supports paging query for workflow execution log

Modifications

inlong-manager: WorkflowController, WorkflowServiceImpl……

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #1697 (2d870d5) into master (61b2bb1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1697   +/-   ##
=========================================
  Coverage     12.21%   12.21%           
  Complexity     1048     1048           
=========================================
  Files           392      392           
  Lines         32755    32755           
  Branches       5159     5159           
=========================================
  Hits           4001     4001           
  Misses        27989    27989           
  Partials        765      765           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b2bb1...2d870d5. Read the comment docs.

Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloyszhang aloyszhang added this to the 0.11.0 milestone Oct 20, 2021
Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit b68bed9 into apache:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INLONG-738] Supports paging query for workflow execution log
5 participants