Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-583] Adjust BrokerConfManager class implementation #462

Merged
merged 1 commit into from
May 9, 2021
Merged

[INLONG-583] Adjust BrokerConfManager class implementation #462

merged 1 commit into from
May 9, 2021

Conversation

gosonzhang
Copy link
Contributor

  1. Replace BrokerConfManager with MetaDataManager;
  2. Clean up useless code implementations

@codecov-commenter
Copy link

Codecov Report

Merging #462 (fd83e71) into TUBEMQ-570 (b3e14b9) will increase coverage by 0.71%.
The diff coverage is 0.93%.

Impacted file tree graph

@@               Coverage Diff               @@
##             TUBEMQ-570    #462      +/-   ##
===============================================
+ Coverage          6.60%   7.32%   +0.71%     
  Complexity          477     477              
===============================================
  Files               300     298       -2     
  Lines             33480   31190    -2290     
  Branches           5573    5045     -528     
===============================================
+ Hits               2212    2284      +72     
+ Misses            30795   28437    -2358     
+ Partials            473     469       -4     
Impacted Files Coverage Δ Complexity Δ
...emq/server/common/paramcheck/PBParameterUtils.java 17.32% <0.00%> (+0.49%) 14.00 <0.00> (ø)
.../tubemq/server/common/utils/WebParameterUtils.java 0.00% <ø> (-1.49%) 0.00 <0.00> (-8.00)
.../java/org/apache/tubemq/server/master/TMaster.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...emq/server/master/balance/DefaultLoadBalancer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bemq/server/master/metamanage/MetaDataManager.java 0.35% <0.00%> (+0.35%) 1.00 <0.00> (+1.00)
...amanage/metastore/dao/entity/BrokerConfEntity.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...er/nodemanage/nodebroker/BrokerSyncStatusInfo.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...emq/server/master/web/MasterStatusCheckFilter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...tubemq/server/master/web/action/screen/Master.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ubemq/server/master/web/action/screen/Tubeweb.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e14b9...fd83e71. Read the comment docs.

@gosonzhang gosonzhang merged commit 73af3f0 into apache:TUBEMQ-570 May 9, 2021
@gosonzhang gosonzhang deleted the TUBEMQ-570 branch May 9, 2021 02:03
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants