Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-617] Add unit tests for WebParameterUtils #471

Merged
merged 3 commits into from
May 24, 2021
Merged

[INLONG-617] Add unit tests for WebParameterUtils #471

merged 3 commits into from
May 24, 2021

Conversation

gosonzhang
Copy link
Contributor

part1. add unit test cases for getStringParamValue, getBooleanParamValue, getAUDBaseInfo, getTopicPropInfo

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #471 (b61b05b) into TUBEMQ-570 (4f68e8a) will increase coverage by 1.22%.
The diff coverage is 2.59%.

Impacted file tree graph

@@               Coverage Diff               @@
##             TUBEMQ-570    #471      +/-   ##
===============================================
+ Coverage          7.04%   8.27%   +1.22%     
- Complexity          466     557      +91     
===============================================
  Files               304     304              
  Lines             30886   30975      +89     
  Branches           4953    4982      +29     
===============================================
+ Hits               2177    2563     +386     
+ Misses            28242   27905     -337     
- Partials            467     507      +40     
Impacted Files Coverage Δ Complexity Δ
...e/tubemq/server/common/statusdef/ManageStatus.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bemq/server/master/metamanage/MetaDataManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../metamanage/metastore/BdbMetaStoreServiceImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...er/metamanage/metastore/dao/entity/BaseEntity.java 23.02% <0.00%> (+23.02%) 9.00 <0.00> (+9.00)
...amanage/metastore/dao/entity/BrokerConfEntity.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...age/metastore/dao/entity/ClusterSettingEntity.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...manage/metastore/dao/entity/TopicDeployEntity.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...etamanage/metastore/dao/entity/TopicPropGroup.java 16.96% <0.00%> (+16.96%) 11.00 <1.00> (+11.00)
...astore/impl/bdbimpl/BdbBrokerConfigMapperImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...re/impl/bdbimpl/BdbGroupConsumeCtrlMapperImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f68e8a...b61b05b. Read the comment docs.

@gosonzhang gosonzhang merged commit 8046ff9 into apache:TUBEMQ-570 May 24, 2021
@gosonzhang gosonzhang deleted the TUBEMQ-570 branch May 24, 2021 02:16
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants