Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-733] Unity the Manger-API/Manger-OpenAPI, and change Manager-API to Manager-Web #598

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

healchow
Copy link
Member

Fixes Jira Issue ID:
https://issues.apache.org/jira/projects/INLONG/issues/INLONG-733

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #598 (18ec8d9) into master (cdcb29e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #598      +/-   ##
===========================================
- Coverage      7.72%   7.72%   -0.01%     
+ Complexity      564     563       -1     
===========================================
  Files           355     355              
  Lines         31081   31081              
  Branches       4972    4972              
===========================================
- Hits           2401    2400       -1     
  Misses        28190   28190              
- Partials        490     491       +1     
Impacted Files Coverage Δ
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.31% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdcb29e...18ec8d9. Read the comment docs.

Copy link
Contributor

@dockerzhang dockerzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang merged commit 01de55d into apache:master Jul 28, 2021
ApocalypseWan pushed a commit to ApocalypseWan/incubator-inlong that referenced this pull request Aug 23, 2021
…API to Manager-Web (apache#598)

Co-authored-by: healzhou <healzhou@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants