Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-655] Update documents of new version TsFile #1186

Merged
merged 5 commits into from May 17, 2020
Merged

Conversation

samperson1997
Copy link
Contributor

@samperson1997 samperson1997 commented May 10, 2020

Update SystemDesign/1-TsFile/2-Format.md and its figures. Add examples for the new structure MetadataIndexNode

@samperson1997 samperson1997 requested a review from HTHou May 10, 2020 09:37
Copy link
Contributor

@HTHou HTHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well down! Nice work. 👍
I just found two tables in doc, which are pageHeader and ChunkHeader need to be changed.

docs/SystemDesign/1-TsFile/2-Format.md Show resolved Hide resolved
docs/zh/SystemDesign/1-TsFile/2-Format.md Show resolved Hide resolved
@samperson1997
Copy link
Contributor Author

Well down! Nice work. 👍
I just found two tables in doc, which are pageHeader and ChunkHeader need to be changed.

Hi Haonan,
Thanks for your help and detailed review! I've fixed the problems. Please give a second review ; )

docs/zh/SystemDesign/1-TsFile/2-Format.md Outdated Show resolved Hide resolved
docs/SystemDesign/1-TsFile/2-Format.md Outdated Show resolved Hide resolved
docs/SystemDesign/1-TsFile/2-Format.md Outdated Show resolved Hide resolved
docs/zh/SystemDesign/1-TsFile/2-Format.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qiaojialin qiaojialin merged commit a7b40b2 into master May 17, 2020
@qiaojialin qiaojialin deleted the tsfile_doc branch May 17, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants