Enable iotdb to set useasyncserver and useasyncapplier through configuration files #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuyilan
requested changes
Jul 31, 2020
| is_use_async_server=true | ||
|
|
||
| #is use sync applier | ||
| is_use_async_applier=true |
There was a problem hiding this comment.
please make the annotation more clearer.
| config.setUseAsyncServer( | ||
| Boolean.parseBoolean(properties.getProperty("is_use_async_server", | ||
| String.valueOf(config.isUseAsyncServer())))); | ||
| logger.info("server+{}",config.isUseAsyncServer()); |
| config.setUseAsyncApplier( | ||
| Boolean.parseBoolean(properties.getProperty("is_use_async_applier", | ||
| String.valueOf(config.isUseAsyncApplier())))); | ||
| logger.info("app+{}",config.isUseAsyncApplier()); |
| is_use_async_server=true | ||
|
|
||
| #is use sync applier | ||
| is_use_async_applier=true |
There was a problem hiding this comment.
the default value is false. make sure consistent with the code
neuyilan
approved these changes
Jul 31, 2020
added 2 commits
July 31, 2020 14:51
jixuan1989
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Thanks for your contribution.
Actually we abstract out these two parameters as the experimental variables to test the performance. We would choose the configuration with the best performance when the distributed version is released, so we do not need to add them to the configuration item at present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is convenient to change the corresponding variables in the code by modifying the configuration file during testing. It is not necessary to change the code and recompile before each test.