Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set props to null by default in createTimeseries to save memory #1753

Closed
wants to merge 1 commit into from
Closed

set props to null by default in createTimeseries to save memory #1753

wants to merge 1 commit into from

Conversation

qiaojialin
Copy link
Member

No description provided.

JackieTien97
JackieTien97 requested changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@JackieTien97 JackieTien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, Collections.emptyMap() always return a same Constant object. I don't think it will save memory. Even if you set the reference to null, the reference itself will take 4B same as before. Overall, EMPTY_MAP is a constant value in Collections, it will be in the memory as long as you use the Collections class.

@qiaojialin
Copy link
Member Author

Thanks Yuan!

@qiaojialin qiaojialin closed this Sep 23, 2020
@qiaojialin qiaojialin deleted the set_props_to_nul branch September 23, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackieTien97 JackieTien97 JackieTien97 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qiaojialin @JackieTien97