New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOTDB-130]Dynamic parameters adapter #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanhualta
force-pushed
the
dynamic_parameters
branch
from
July 10, 2019 11:44
7f25171
to
e3ccc40
Compare
fanhualta
force-pushed
the
dynamic_parameters
branch
from
July 10, 2019 16:18
dadabc7
to
c9665db
Compare
fanhualta
force-pushed
the
dynamic_parameters
branch
from
July 11, 2019 02:07
c9665db
to
d438e0b
Compare
fanhualta
force-pushed
the
dynamic_parameters
branch
from
July 11, 2019 03:16
23bf543
to
121df94
Compare
qiaojialin
reviewed
Jul 11, 2019
qiaojialin
reviewed
Jul 11, 2019
iotdb/src/main/java/org/apache/iotdb/db/conf/adapter/IDynamicAdapter.java
Outdated
Show resolved
Hide resolved
qiaojialin
reviewed
Jul 11, 2019
iotdb/src/main/java/org/apache/iotdb/db/conf/adapter/IoTDBConfigDynamicAdapter.java
Outdated
Show resolved
Hide resolved
qiaojialin
reviewed
Jul 11, 2019
iotdb/src/main/java/org/apache/iotdb/db/conf/adapter/IoTDBConfigDynamicAdapter.java
Outdated
Show resolved
Hide resolved
qiaojialin
reviewed
Jul 11, 2019
iotdb/src/main/java/org/apache/iotdb/db/conf/adapter/IoTDBConfigDynamicAdapter.java
Outdated
Show resolved
Hide resolved
qiaojialin
approved these changes
Jul 11, 2019
jixuan1989
reviewed
Jul 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have read all changes except UTs... I think it is almost fine, but the CompressionRatio class and IoTDBConfigDynamicAdapter class should have more comments...
iotdb/src/main/java/org/apache/iotdb/db/conf/adapter/CompressionRatio.java
Outdated
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/conf/adapter/CompressionRatio.java
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/conf/adapter/IoTDBConfigDynamicAdapter.java
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/conf/adapter/IoTDBConfigDynamicAdapter.java
Outdated
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/conf/adapter/IoTDBConfigDynamicAdapter.java
Outdated
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
Outdated
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/qp/executor/QueryProcessExecutor.java
Outdated
Show resolved
Hide resolved
iotdb/src/main/java/org/apache/iotdb/db/qp/executor/QueryProcessExecutor.java
Outdated
Show resolved
Hide resolved
…b into dynamic_parameters
…b into dynamic_parameters t push
…; remove wait 5s in IoTDBAggregationSmallDataIT
Hi, can you report the performance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable the system to run normally under different loads and not explode memory, it is necessary to dynamically adjust some parameters which play a decisive role in the system memory usage to adapt the load according to the system's operating conditions. Therefore, in this pr, I develop a dynamic parameter adaptation function to fulfill the above requirements.
corresponding jira issue link: https://issues.apache.org/jira/browse/IOTDB-130