Add micro and nano timestamp precision #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaojialin
requested changes
Jul 23, 2019
|
|
||
| public class IoTDBConfigCheck { | ||
|
|
||
| // this file is located in Data/System/Schema/system_properties. |
There was a problem hiding this comment.
Suggested change
| // this file is located in Data/System/Schema/system_properties. | |
| // this file is located in data/system/schema/system.properties |
| public class IoTDBConfigCheck { | ||
|
|
||
| // this file is located in Data/System/Schema/system_properties. | ||
| // If user delete folder "Data", system_properties can reset. |
There was a problem hiding this comment.
Suggested change
| // If user delete folder "Data", system_properties can reset. | |
| // If user delete folder "data", system.properties can reset. |
| // If user delete folder "Data", system_properties can reset. | ||
| public static final String DEFAULT_FILEPATH = "system.properties"; | ||
| public static final String PROPERTY_HOME = | ||
| "data" + File.separator + "system" + File.separator + "schema"; |
There was a problem hiding this comment.
Suggested change
| "data" + File.separator + "system" + File.separator + "schema"; | |
| IoTDBDescriptor.getInstance().getConfig().getSystemDIr() + File.separator + "schema"; |
| File dir = new File(filepath); | ||
| if (!dir.exists()) { | ||
| dir.mkdirs(); | ||
| logger.info(" {} dir has been made.", PROPERTY_HOME); |
There was a problem hiding this comment.
Suggested change
| logger.info(" {} dir has been made.", PROPERTY_HOME); | |
| logger.info(" {} dir has been created.", PROPERTY_HOME); |
| // this file is located in Data/System/Schema/system_properties. | ||
| // If user delete folder "Data", system_properties can reset. | ||
| public static final String DEFAULT_FILEPATH = "system.properties"; | ||
| public static final String PROPERTY_HOME = |
There was a problem hiding this comment.
Suggested change
| public static final String PROPERTY_HOME = | |
| public static final String SCHEMA_DIR = |
| private static final Logger logger = LoggerFactory.getLogger(IoTDBDescriptor.class); | ||
| private Properties properties = new Properties(); | ||
| // this is a initial parameter. | ||
| public static String TIMESTAMP_PRECISION = "ms"; |
There was a problem hiding this comment.
Just use a local variable is good
|
|
||
| // this file is located in Data/System/Schema/system_properties. | ||
| // If user delete folder "Data", system_properties can reset. | ||
| public static final String DEFAULT_FILEPATH = "system.properties"; |
There was a problem hiding this comment.
Suggested change
| public static final String DEFAULT_FILEPATH = "system.properties"; | |
| public static final String PROPERTIES_FILE_NAME = "system.properties"; |
| // get existed properties from system_properties.txt | ||
| File inputFile = new File(filepath + File.separator + DEFAULT_FILEPATH); | ||
| try (FileInputStream inputStream = new FileInputStream(inputFile.toString())) { | ||
| properties.load(new InputStreamReader(inputStream, "utf-8")); |
There was a problem hiding this comment.
Suggested change
| properties.load(new InputStreamReader(inputStream, "utf-8")); | |
| properties.load(new InputStreamReader(inputStream, TSFILEConfig.STRING_ENCODING)); |
* Fix 'latest' in documents link url to version number
qiaojialin
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IoTDB only provide millisecond timestamp. Therefore, I make an effort to help IoTDB recognizing microsecond and nanosecond timestamp while inserting or querying.