Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOTDB-154] Remove unuseful package.sh and fix a url in pom.xml. #304

Merged
merged 2 commits into from
Jul 26, 2019
Merged

[IOTDB-154] Remove unuseful package.sh and fix a url in pom.xml. #304

merged 2 commits into from
Jul 26, 2019

Conversation

Genius-pig
Copy link
Contributor

@jixuan1989
Copy link
Member

Thanks for your carefully modification.
Indeed the package.sh is a legacy when we are not familiar with using Maven to do these things.. It can be removed I think. How about you @qiaojialin

@Genius-pig
Copy link
Contributor Author

@jixuan1989 The problem is that it can't be used, like ./target/lib/*.jar doesn't exist.

@qiaojialin
Copy link
Member

Thanks for your carefully modification.
Indeed the package.sh is a legacy when we are not familiar with using Maven to do these things.. It can be removed I think. How about you @qiaojialin

+1 for removing that

@qiaojialin qiaojialin merged commit e2e5a84 into apache:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiaojialin qiaojialin qiaojialin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Genius-pig @jixuan1989 @qiaojialin