[IOTDB-189] Support compatibility of HDFS File and Java File #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt2594838
reviewed
Sep 5, 2019
tsfile/src/main/java/org/apache/iotdb/tsfile/fileSystem/IoTDBFile.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/fileSystem/IoTDBFile.java
Outdated
Show resolved
Hide resolved
tsfile/src/main/java/org/apache/iotdb/tsfile/fileSystem/IoTDBFile.java
Outdated
Show resolved
Hide resolved
qiaojialin
reviewed
Sep 5, 2019
tsfile/src/main/java/org/apache/iotdb/tsfile/fileSystem/IoTDBFile.java
Outdated
Show resolved
Hide resolved
qiaojialin
reviewed
Sep 5, 2019
qiaojialin
reviewed
Sep 5, 2019
tsfile/src/main/java/org/apache/iotdb/tsfile/fileSystem/IoTDBFileFactory.java
Outdated
Show resolved
Hide resolved
qiaojialin
reviewed
Sep 5, 2019
tsfile/src/main/java/org/apache/iotdb/tsfile/fileSystem/IoTDBFileFactory.java
Outdated
Show resolved
Hide resolved
jt2594838
reviewed
Sep 6, 2019
qiaojialin
approved these changes
Sep 6, 2019
added 11 commits
September 6, 2019 17:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to resolve requirement IOTDB-187: "Enabling to choose storage in local file system or HDFS".
This step contains:
storage_fs(defaultLOCAL, could beHDFSetc) iniotdb-engine.propertiesfor users to config.FileFactoryto get files by configuration inIoTDBConfig.HdfsFilewhich extendsjava.io.fileand rewrite methods in HDFS ways (may have some bugs, will be fixed in next steps)After these steps, we could use
FileFactory.INSTANCE.getFile(...)to get "file" according to configured file system, which supports compatibility of HDFS file and java file.