refactor chunk reader #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt2594838
approved these changes
Dec 26, 2019
tsfile/src/test/java/org/apache/iotdb/tsfile/read/reader/PageReaderTest.java
Outdated
Show resolved
Hide resolved
jixuan1989
approved these changes
Dec 26, 2019
| currentChunkMetaDataList = tsFileResource.getChunkMetaDataList(); | ||
| } | ||
|
|
||
| // get modifications and apply to chunk metadatas | ||
| List<Modification> pathModifications = context |
There was a problem hiding this comment.
need a ut?
Or, in logical, can the PathModifications file be read before the data file is sealed?
There was a problem hiding this comment.
no bug, I have added some test and comment
jt2594838
approved these changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hasNext() and only keep one getData in PageReader.
Remove unused parameter in BatchData