abstract TsFileFlushPolicy and allow specifying storage groups in flush command #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanhualta
requested changes
Dec 31, 2019
server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
Outdated
Show resolved
Hide resolved
fanhualta
approved these changes
Jan 2, 2020
qiaojialin
approved these changes
Jan 3, 2020
server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
Outdated
Show resolved
Hide resolved
…java Co-Authored-By: Jialin Qiao <qjl16@mails.tsinghua.edu.cn>
# Conflicts: # server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the different replicas of a data partition consistent, the distributed version needs to force all replicas close file by the leader instead of on their own. So the TsFileFlushPolicy is abstracted to make this behavior controllable.
Moreover, since the leader should be able to make a follower close one of its storage group, the grammar of the flush command is enhanced to support finer granularity.