[IOTDB-417] Made all tests Locale Invariant by always explicitly defaulting to Locale.ENGLISH

[JulianFeinauer]

…cale.ENGLISH.

Fixes comment in my VOTE Email https://lists.apache.org/thread.html/rfef7f0035f28c3ee81ce32135e46e53774ce19b4af0bc06db426d4e3%40%3Cdev.iotdb.apache.org%3E

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[sunjincheng121]

I would like to have a look.

[sunjincheng121]

Thanks for the PR @JulianFeinauer
The PR looks good to me for fix this issue, I only left one comment for simple the code change and one suggestion as follows:

I checked the entire project and found that String.format is used in many places(not only in test code). We are fortunate to find this Local problem in ITCase, but we cannot rule out that there are unpredictable problems hidden in other places, so I think would be better make a util similar with String.format in IoTDB , and set the configuration we need in the util, such as Local information, so that even if other problems are found in the future, we can fix it as a whole by modifying one place.

What do you think? @JulianFeinauer @jixuan1989

[sunjincheng121]

Just a suggestion: could you please set the default local in setUp(), e.g., Locale.setDefault(Locale.ENGLISH);, then we only need one line change.
What do you think?

[jixuan1989]

Thanks for the PR @JulianFeinauer
The PR looks good to me for fix this issue, I only left one comment for simple the code change and one suggestion as follows:

I checked the entire project and found that String.format is used in many places(not only in test code). We are fortunate to find this Local problem in ITCase, but we cannot rule out that there are unpredictable problems hidden in other places, so I think would be better make a util similar with String.format in IoTDB , and set the configuration we need in the util, such as Local information, so that even if other problems are found in the future, we can fix it as a whole by modifying one place.

What do you think? @JulianFeinauer @jixuan1989

I think many String.format() is used for log. Because all messages are in English, I wonder why a Locale is needed...

[JulianFeinauer]

Excellent idea... The issue is that with e. G German locals decimal points are printed as comma...

[JulianFeinauer]

@jixuan1989 if String.format is used for log only we have no issue but in the places above it is used to concatenate (or expand) Query Strings. And here, for some Locales (like e.g. German) the decimal points are expanded to decimal commas which leads to syntactically wrong statements, of course. So this, for sure, has to be Locale Invariant!

[jixuan1989]

I have checked. All String.format are used for either printing log or test. So, it should be ok.