Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs of add duplicated metadata #918

Merged
merged 3 commits into from Mar 17, 2020

Conversation

fanhualta
Copy link
Contributor

@fanhualta fanhualta commented Mar 17, 2020

When adding metadata which already exists in the engine. Previously, its result is as follow:
image

It's caused by not checking existence when adding metadata.
In this case, when you restart the engine, you will query nothing from the engine:
image

@fanhualta fanhualta changed the title Fix bugs of add duplicated bugs Fix bugs of add duplicated metadata Mar 17, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qiaojialin qiaojialin merged commit a92b80c into master Mar 17, 2020
@qiaojialin qiaojialin deleted the fix_add_duplicated_metadata_bug branch March 17, 2020 15:39
fanhualta added a commit that referenced this pull request Mar 18, 2020
@fanhualta fanhualta restored the fix_add_duplicated_metadata_bug branch March 18, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants