Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links in Deploying a New Workflow section #468

Closed
gciavarrini opened this issue Aug 23, 2023 · 2 comments
Closed

Broken links in Deploying a New Workflow section #468

gciavarrini opened this issue Aug 23, 2023 · 2 comments

Comments

@gciavarrini
Copy link
Contributor

In Deploying a New Workflow section, there are two broken links:

Deploying the greeting Workflow example

kubectl apply -f https://raw.githubusercontent.com/kiegroup/kogito-serverless-operator/main/test/testdata/sw.kogito_v1alpha08_sonataflow_devmode.yaml -n <your_namespace>

The link should be replaced with https://github.com/kiegroup/kogito-serverless-operator/blob/main/test/testdata/sonataflow.org_v1alpha08_sonataflow_devmode.yaml

At the end of the same section, there is a similar issue with

For example using VSCode, there are the commands needed:

curl -S https://raw.githubusercontent.com/kiegroup/kogito-serverless-operator/main/config/samples/sw.kogito_v1alpha08_sonataflow_devmode.yaml > workflow_devmode.yaml
code workflow_devmode.yaml
kubectl apply -f workflow_devmode.yaml -n <your_namespace>

In this case, there is no sonataflow.org_v1alpha08_sonataflow_devmode.yaml in /config/samples folder. Since the guide require sonataflow.org/profile: dev the only applicable config seems to be sonataflow.org_v1alpha08_sonataflow_devmodeWithConfigMapAndExternalResource.yaml
Is it correct?

I'd be happy to open a PR to fix this, but I need a bit of guidance here :)

@ricardozanini
Copy link
Member

Hi @gciavarrini many thanks for reporting it! Can you send a PR? It's pretty straightforward. Here are the files: https://github.com/kiegroup/kogito-docs/tree/main/serverlessworkflow/modules/ROOT/pages

@MarianMacik
Copy link
Member

MarianMacik commented Oct 12, 2023

Fixed in #500. Thank you @gciavarrini for help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants