Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[KYUUBI #2719] [SUB-TASK][KPIP-4] Support internal rest request authe…
…ntication to enable http request redirection across kyuubi instances ### _Why are the changes needed?_ Support internal rest request authentication to enable redirect http request across kyuubi instances ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2719 from turboFei/internal_access. Closes #2719 b9e150e [Fei Wang] revert config key change aa37872 [Fei Wang] make it internal ce96d92 [Fei Wang] comments 6fe8523 [Fei Wang] Support internal rest request authentication to enable redirect http request across kyuubi instances Authored-by: Fei Wang <fwang12@ebay.com> Signed-off-by: Fei Wang <fwang12@ebay.com>
- Loading branch information
Showing
14 changed files
with
152 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...la/org/apache/kyuubi/server/http/authentication/KyuubiInternalAuthenticationHandler.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.kyuubi.server.http.authentication | ||
|
|
||
| import java.nio.charset.Charset | ||
| import java.util.Base64 | ||
| import javax.servlet.http.{HttpServletRequest, HttpServletResponse} | ||
|
|
||
| import org.apache.kyuubi.Logging | ||
| import org.apache.kyuubi.config.KyuubiConf | ||
| import org.apache.kyuubi.server.http.authentication.AuthSchemes.AuthScheme | ||
| import org.apache.kyuubi.service.authentication.InternalSecurityAccessor | ||
|
|
||
| class KyuubiInternalAuthenticationHandler extends AuthenticationHandler with Logging { | ||
| import AuthenticationHandler._ | ||
|
|
||
| private var conf: KyuubiConf = _ | ||
| override val authScheme: AuthScheme = AuthSchemes.KYUUBI_INTERNAL | ||
| private val internalSecurityAccessor = InternalSecurityAccessor.get() | ||
|
|
||
| override def init(conf: KyuubiConf): Unit = { | ||
| this.conf = conf | ||
| } | ||
|
|
||
| override def authenticationSupported: Boolean = { | ||
| internalSecurityAccessor != null | ||
| } | ||
|
|
||
| override def authenticate( | ||
| request: HttpServletRequest, | ||
| response: HttpServletResponse): String = { | ||
| var authUser: String = null | ||
| val authorization = getAuthorization(request) | ||
| val inputToken = Option(authorization).map(a => Base64.getDecoder.decode(a.getBytes())) | ||
| .getOrElse(Array.empty[Byte]) | ||
| val creds = new String(inputToken, Charset.forName("UTF-8")).split(":") | ||
|
|
||
| if (creds.size < 2 || creds(0).trim.isEmpty || creds(1).trim.isEmpty) { | ||
| response.setHeader(WWW_AUTHENTICATE, authScheme.toString) | ||
| response.setStatus(HttpServletResponse.SC_UNAUTHORIZED) | ||
| } else { | ||
| val Seq(user, password) = creds.toSeq.take(2) | ||
| internalSecurityAccessor.authToken(password) | ||
| response.setStatus(HttpServletResponse.SC_OK) | ||
| authUser = user | ||
| } | ||
| authUser | ||
| } | ||
|
|
||
| override def destroy(): Unit = {} | ||
| } |
Oops, something went wrong.