Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport HIVE-19018 to Kyuubi Beeline #2478

Closed
2 of 3 tasks
pan3793 opened this issue Apr 25, 2022 · 2 comments
Closed
2 of 3 tasks

Backport HIVE-19018 to Kyuubi Beeline #2478

pan3793 opened this issue Apr 25, 2022 · 2 comments
Assignees
@jiaoqingbo
Labels
good first issue beginner skills required help wanted

Comments

@pan3793
Copy link
Member

pan3793 commented Apr 25, 2022 •
edited

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Allow sql w/o ; at end to execute when using beeline -e 'sql'

How should we improve?

Backport apache/hive@52290e7

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@pan3793 pan3793 added help wanted good first issue beginner skills required labels Apr 26, 2022
@jiaoqingbo
Copy link
Contributor

please assgin this to me

jiaoqingbo added a commit to jiaoqingbo/incubator-kyuubi that referenced this issue Apr 27, 2022
@jiaoqingbo
[KYUUBI apache#2478] Backport HIVE-19018 to Kyuubi Beeline
0e127c6
@jiaoqingbo jiaoqingbo mentioned this issue Apr 27, 2022
Closed
3 tasks
@yaooqinn
Copy link
Member

shall we also add a doc or faq?

turboFei pushed a commit that referenced this issue Apr 27, 2022
@jiaoqingbo @turboFei
[KYUUBI #2478] Backport HIVE-19018 to Kyuubi Beeline
fbe38de 
### _Why are the changes needed?_

fix #2478

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2489 from jiaoqingbo/2478.

Closes #2478

3565e58 [jiaoqingbo] invoke CI
0e127c6 [jiaoqingbo] [KYUUBI #2478] Backport HIVE-19018 to Kyuubi Beeline

Authored-by: jiaoqingbo <1178404354@qq.com>
Signed-off-by: Fei Wang <fwang12@ebay.com>
(cherry picked from commit 268db01)
Signed-off-by: Fei Wang <fwang12@ebay.com>
turboFei added a commit to turboFei/kyuubi that referenced this issue Apr 29, 2022
@turboFei
[KYUUBI apache#2478][FOLLOWUP] Invoke getOpts method instead of Refle…
2a2070b 
…ction
turboFei added a commit to turboFei/kyuubi that referenced this issue Apr 29, 2022
@turboFei
[KYUUBI apache#2478][FOLLOWUP] Invoke getOpts method instead of Refle…
4400f36 
…ction
turboFei added a commit that referenced this issue Apr 29, 2022
@turboFei
[KYUUBI #2478][FOLLOWUP] Invoke getOpts method instead of Reflection
cdfae8d 
### _Why are the changes needed?_

Remove unneeded reflection.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #2518 from turboFei/hive_beeline.

Closes #2478

f188d78 [Fei Wang] comment
4400f36 [Fei Wang] [KYUUBI #2478][FOLLOWUP] Invoke getOpts method instead of Reflection

Authored-by: Fei Wang <fwang12@ebay.com>
Signed-off-by: Fei Wang <fwang12@ebay.com>
@turboFei turboFei mentioned this issue Jul 8, 2022
Closed
3 tasks
turboFei pushed a commit that referenced this issue Jul 9, 2022
@jiaoqingbo @turboFei
[KYUUBI #2478][FOLLOWUP] Fix bin/beeline without -u exits unexpectedly
e492994 
### _Why are the changes needed?_

fix #3030

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate
![image](https://user-images.githubusercontent.com/14961757/177953720-029882e5-2454-4091-aa75-d008e15ee1a0.png)

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #3031 from jiaoqingbo/kyuubi-3030.

Closes #2478

58ba011 [jiaoqingbo] change junit location
a4130da [jiaoqingbo] add license
9ff1366 [jiaoqingbo] [KYUUBI #3030] fix bin/beeline without -u exits unexpectedly

Authored-by: jiaoqingbo <1178404354@qq.com>
Signed-off-by: Fei Wang <fwang12@ebay.com>
turboFei pushed a commit that referenced this issue Jul 9, 2022
@jiaoqingbo @turboFei
[KYUUBI #2478][FOLLOWUP] Fix bin/beeline without -u exits unexpectedly
f3bd137 
### _Why are the changes needed?_

fix #3030

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate
![image](https://user-images.githubusercontent.com/14961757/177953720-029882e5-2454-4091-aa75-d008e15ee1a0.png)

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #3031 from jiaoqingbo/kyuubi-3030.

Closes #2478

58ba011 [jiaoqingbo] change junit location
a4130da [jiaoqingbo] add license
9ff1366 [jiaoqingbo] [KYUUBI #3030] fix bin/beeline without -u exits unexpectedly

Authored-by: jiaoqingbo <1178404354@qq.com>
Signed-off-by: Fei Wang <fwang12@ebay.com>
pan3793 added a commit to pan3793/kyuubi that referenced this issue Jul 11, 2022
@pan3793
[KYUUBI apache#2478][FOLLOWUP] Fix junit dependency
f006202
@pan3793 pan3793 mentioned this issue Jul 11, 2022
Closed
3 tasks
pan3793 added a commit that referenced this issue Jul 11, 2022
@pan3793
[KYUUBI #2478][FOLLOWUP][1.5] Fix junit dependency
bdc214d 
### _Why are the changes needed?_

Branch 1.5 is broken now, fix junit dependency.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #3038 from pan3793/junit-1.5.

Closes #2478

f006202 [Cheng Pan] [KYUUBI #2478][FOLLOWUP] Fix junit dependency

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiaoqingbo jiaoqingbo

Labels
good first issue beginner skills required help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #2478] Backport HIVE-19018 to Kyuubi Beeline jiaoqingbo/incubator-kyuubi
3 participants
@yaooqinn @jiaoqingbo @pan3793