Backport HIVE-20583 - Use canonical hostname only for kerberos auth in HiveConnection #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxzl25
approved these changes
Aug 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #3355 +/- ##
============================================
- Coverage 51.48% 51.46% -0.03%
Complexity 13 13
============================================
Files 475 475
Lines 26481 26486 +5
Branches 3695 3697 +2
============================================
- Hits 13635 13630 -5
- Misses 11517 11528 +11
+ Partials 1329 1328 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks, merging to master/1.6 |
pan3793
added a commit
that referenced
this pull request
Aug 26, 2022
…kerberos auth in HiveConnection ### _Why are the changes needed?_ Fix #3352 [HIVE-17218](https://issues.apache.org/jira/browse/HIVE-17218): Canonical-ize hostnames for Hive metastore, and HS2 servers This may have the problem mentioned by JIRA [HIVE-20583](https://issues.apache.org/jira/browse/HIVE-20583): Use canonical hostname only for kerberos auth in HiveConnection ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3355 from pan3793/HIVE-20583. Closes #3355 6e2ffa4 [Cheng Pan] Fix NPE f09b8e6 [Cheng Pan] Backport HIVE-20583 Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 1163a76) Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fix #3352
HIVE-17218: Canonical-ize hostnames for Hive metastore, and HS2 servers
This may have the problem mentioned by JIRA
HIVE-20583: Use canonical hostname only for kerberos auth in HiveConnection
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request