Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat merge ecp to manager #3476

Merged
merged 3 commits into from Oct 11, 2022

Conversation

jackxu2011
Copy link
Contributor

@jackxu2011 jackxu2011 commented Sep 20, 2022

What is the purpose of the change

Now there are too many Linkis services, and ECP is responsible for managing the materials of EngineConn. As a management service, it is better to merge it into the LinkisManager service.
现在Linkis服务过多,而ECP负责管理EngineConn的物料,作为管理服务,建议合并到LinkisManager服务更好

Related issues/PRs

Related issues: #3466

Brief change log

  • merge the ecp to linkismanager
  • modify the install shell

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #3476 (e9d63bd) into dev-1.3.1 (88ddb19) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##             dev-1.3.1    #3476      +/-   ##
===============================================
- Coverage        14.32%   14.29%   -0.03%     
+ Complexity        1524     1523       -1     
===============================================
  Files             1032     1032              
  Lines            38177    38197      +20     
  Branches          5372     5375       +3     
===============================================
- Hits              5469     5461       -8     
- Misses           31974    32003      +29     
+ Partials           734      733       -1     
Impacted Files Coverage Δ
.../src/main/scala/org/apache/linkis/rpc/Sender.scala 0.00% <0.00%> (ø)
.../org/apache/linkis/rpc/conf/RPCConfiguration.scala 0.00% <0.00%> (ø)
...n/scala/org/apache/linkis/rpc/utils/RPCUtils.scala 0.00% <0.00%> (ø)
.../queue/parallelqueue/ParallelConsumerManager.scala 19.35% <0.00%> (-12.91%) ⬇️
...r/engineplugin/python/executor/PythonSession.scala 58.91% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/2.3"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/2.3 http://maven.apache.org/xsd/assembly-1.1.2.xsd">
<id>linkis-publicservice</id>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id need to update

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit e9f70eb into apache:dev-1.3.1 Oct 11, 2022
@jackxu2011 jackxu2011 deleted the feat-mergeEcpToManager branch October 13, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants