New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat merge ecp to manager #3476
Feat merge ecp to manager #3476
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-1.3.1 #3476 +/- ##
===============================================
- Coverage 14.32% 14.29% -0.03%
+ Complexity 1524 1523 -1
===============================================
Files 1032 1032
Lines 38177 38197 +20
Branches 5372 5375 +3
===============================================
- Hits 5469 5461 -8
- Misses 31974 32003 +29
+ Partials 734 733 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9d997c6
to
280791b
Compare
280791b
to
e9d63bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/2.3" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/2.3 http://maven.apache.org/xsd/assembly-1.1.2.xsd"> | ||
<id>linkis-publicservice</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id need to update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Now there are too many Linkis services, and ECP is responsible for managing the materials of EngineConn. As a management service, it is better to merge it into the LinkisManager service.
现在Linkis服务过多,而ECP负责管理EngineConn的物料,作为管理服务,建议合并到LinkisManager服务更好
Related issues/PRs
Related issues: #3466
Brief change log
Checklist