Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Hot Loading #3841

Merged

Conversation

binbinCheng
Copy link
Contributor

What is the purpose of the change

Configure Hot Loading

var tmpConfigPath = ""
var tmpConfig = new Properties()
Utils.tryCatch {
// 刷新配置
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use EN

@@ -266,7 +266,7 @@ public Message progress(@PathVariable("id") String id) {
} else {
List<Map<String, Object>> list = new ArrayList<>();
for (JobProgressInfo jobProgressInfo : jobProgressInfos) {
if ("true".equals(EntranceConfiguration.PROGRESS_PUSH().getValue())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not need to use hot value

@@ -140,7 +140,8 @@ class CliHeartbeatMonitor(handler: HeartbeatLossHandler) extends Logging {
logger.debug("ClientHeartbeatMonitor ends scanning for one iteration")
}

private val monitorCreators = EntranceConfiguration.CLIENT_MONITOR_CREATOR.getValue.split(",")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not need to use hot value

@@ -32,7 +32,7 @@ class EntranceEventListenerBus[L <: EntranceEventListener, E <: EntranceEvent](
def this(eventQueueCapacity: Int) =
this(eventQueueCapacity, DataWorkCloudApplication.getApplicationName + "-EventListenerBus")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not need to use hot value

@@ -39,7 +39,7 @@ class JobTimeoutManager extends Logging {
new ConcurrentHashMap[String, EntranceJob]

val timeoutCheck: Boolean = EntranceConfiguration.ENABLE_JOB_TIMEOUT_CHECK.getValue
val timeoutScanInterval: Int = EntranceConfiguration.TIMEOUT_SCAN_INTERVAL.getValue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not need to use hot value

serviceInstance.getApplicationName match {
case GovernanceCommonConf.ENGINE_CONN_SPRING_NAME.getValue =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback

@@ -22,25 +22,30 @@ import org.apache.linkis.storage.utils.{StorageConfiguration, StorageUtils}

class FsProxyService extends Logging {

def canProxyUser(creatorUser: String, proxyUser: String, fsType: String): Boolean =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback

Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 913a437 into apache:dev-1.3.2 Nov 17, 2022
@binbinCheng binbinCheng deleted the dev-1.3.2-new-config-hot-reload branch December 9, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants