This repository has been archived by the owner on May 12, 2021. It is now read-only.
(abort)METRON-449 - JSON Parser should unfold nested maps #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into METRON-434
The JSONMapParser only supports unfolding of maps at the root of the JSON object. It would be better if it could unfold to arbitrary depths for broader range of support. This is added by introducing recursion to the UNFOLD functionality. Because you can’t self reference in the enum lambda, I have added a private function which can recurse and had the lambda call that. It is possible that there is a better way to implement this, so hopefully that will come out in review.
|
I don't think I should be carrying the other commits. I didn't rebase. I'll redo |
ottobackwards
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For greater flexibility and utility the JSONMapParser should support unfolding maps to arbitrary depths.
This change introduces a new function called recursively to handle this, because the enum lambdas cannot reference themselves.