-
Notifications
You must be signed in to change notification settings - Fork 512
Metron 451 SerDeUtils - java.lang.ClassNotFoundException: org.apache.storm.shade.org.joda.time.DateTime #278
Conversation
SerDeUtils - java.lang.ClassNotFoundException: org.apache.storm.shade.org.joda.time.DateTime Took the same jodatime dependency from API's pom and put it in Common's pom. Not sure how this was building otherwise--it should not have been build-able without this dependency visible to this module. Suggest adding the version number as a variable that is controlled at a parent pom's dependency management section, so that the version numbers don't get out of sync between modules.
# By cstella (4) and others # Via cstella * 'master' of https://github.com/apache/incubator-metron: METRON-457 Correct GrokParser logging spelling error (mmiklavc via cestella) closes apache#274 METRON-449 JSONMapParser should unfold maps to arbitrary depths closes apache#271 METRON-453: Add a stellar shell function to open an external editor and return the editor's contents closes apache#272 METRON-452: Add rudimentary configuration management functions to Stellar closes apache#269 METRON-374: Add appropriate bundled 3rd party licenses to NOTICE and LICENSE where appropriate closes apache#229 flush METRON-427 Create Ambari Management Pack for Metron Installation closes apache#266
This reverts commit 1e45d05.
SerDeUtils - java.lang.ClassNotFoundException: org.apache.storm.shade.org.joda.time.DateTime Took the same jodatime dependency from API's pom and put it in Common's pom. Not sure how this was building otherwise--it should not have been build-able without this dependency visible to this module. Suggest adding the version number as a variable that is controlled at a parent pom's dependency management section, so that the version numbers don't get out of sync between modules.
The license check failed. Take a look at the |
It would be great if we could add a unit test that exercises this bug. |
@nickwallen , interesting because the jodatime dependency is already in that CSV (it was included in API, but had to add it to the Common module pom) Seems to be failing at the same place as METRON-363 Fix Cisco ASA Parser :
|
Am I supposed to be able to build Metron from the command line on a Mac with Java 8? |
So, maven from the command line should work. Also the tests do function from intellij, I can attest. |
Thanks for the info @cestella ! I get build success on all the modules if I do I think the integrations tests in maas-common that are getting triggered are causing builds to fail for me. (Could be others if it would get passed that). I'll open a new ticket so this doesn't get lost in the weeds on this thread. |
@danieljue - can you merge this branch with master? hopefully then we can get a clean CI build. if we get a good build, we can get your PR committed. |
Actually sorry, I was thinking of your other outstanding PR. For this one, I think we need some way to test the change. If you can provide a means for testing, we can get some reviewers on this. |
Roger that, will devise a test. |
SerDeUtils - java.lang.ClassNotFoundException: org.apache.storm.shade.org.joda.time.DateTime
…nto METRON-451 # By danieljue (1) and ottobackwards (1) # Via Nick Allen * 'master' of https://github.com/apache/incubator-metron: METRON-459 Bad file location for org.apache.metron.spout.pcap.Endianness.java (danieljue via nickwallen) closes apache#275 METRON-474 Fix Vagrant Ansible Defaults for Quick & Full Dev (ottobackwards via nickwallen) closes apache#284
What is the status of this? |
This PR will be closed soon if not updated. Is there any update for it's status? |
@danieljue Please close this PR unless you believe it is still needed. This PR will be closed per the Metron Development Guidelines on Inactive PRs, unless you provide some reasoning as to why it is stil needed. Thanks! |
-1 Based on the Metron Development Guidelines on Inactive PRs. Missing contributor feedback. I will open an Apache Infra request to close this PR. |
Fix for METRON-451
SerDeUtils - java.lang.ClassNotFoundException: org.apache.storm.shade.org.joda.time.DateTime
Sorry guys and gals, forgot to put this fix in it's own branch, might have screwed up previous PR.