Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-742: Generated code for profile window selector DSL did not get committed as part of METRON-690 #466

Closed
wants to merge 1 commit into from

Conversation

cestella
Copy link
Member

Lest we be concerned this implies that the testing done on 690 is voided, this was due to the removal of the NOW lexical token, which was unused in the grammar, along with a really dumb refactoring mistake changing "parse" to "processing" that only hit generated code. The unit tests, etc. ran the code in this PR since it was generated as part of the build.

This brings me to an interesting question that we might want to discuss. Early on, we decided to submit generated code to ease potential issues around pulling code into IDEs (generated code means we don't have to either remind people to rerun mvn generate-sources or to instruct their IDEs to regenerate sources automatically). Maybe we should revisit that point, but I don't know, it's just a thought.

@ottobackwards
Copy link
Contributor

So - the test is - build without changing anything after clone, and there should not be shown in git status right?

@cestella
Copy link
Member Author

Yep

@ottobackwards
Copy link
Contributor

Does building or running the tests have anything to do with it?

@cestella
Copy link
Member Author

It shouldn't because the tests are already run with the code submitted in this PR. This is just about getting git in sync with what's generated.

@ottobackwards
Copy link
Contributor

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Metron ............................................. SUCCESS [ 0.002 s]
[INFO] metron-analytics ................................... SUCCESS [ 0.000 s]
[INFO] metron-maas-common ................................. SUCCESS [ 0.800 s]
[INFO] metron-platform .................................... SUCCESS [ 0.001 s]
[INFO] metron-test-utilities .............................. SUCCESS [ 0.357 s]
[INFO] metron-integration-test ............................ SUCCESS [ 2.171 s]
[INFO] metron-maas-service ................................ SUCCESS [ 1.720 s]
[INFO] metron-common ...................................... SUCCESS [ 40.376 s]
[INFO] metron-statistics .................................. SUCCESS [01:03 min]
[INFO] metron-hbase ....................................... SUCCESS [01:11 min]
[INFO] metron-profiler-common ............................. SUCCESS [ 10.194 s]
[INFO] metron-profiler-client ............................. SUCCESS [01:30 min]
[INFO] metron-profiler .................................... SUCCESS [ 29.689 s]
[INFO] metron-writer ...................................... SUCCESS [ 15.689 s]
[INFO] metron-enrichment .................................. SUCCESS [ 49.701 s]
[INFO] metron-indexing .................................... SUCCESS [ 11.529 s]
[INFO] metron-solr ........................................ SUCCESS [ 13.183 s]
[INFO] metron-pcap ........................................ SUCCESS [ 0.785 s]
[INFO] metron-parsers ..................................... SUCCESS [ 48.027 s]
[INFO] metron-pcap-backend ................................ SUCCESS [ 29.235 s]
[INFO] metron-data-management ............................. SUCCESS [01:11 min]
[INFO] metron-api ......................................... SUCCESS [ 26.331 s]
[INFO] metron-management .................................. SUCCESS [ 39.091 s]
[INFO] elasticsearch-shaded ............................... SUCCESS [ 5.547 s]
[INFO] metron-elasticsearch ............................... SUCCESS [ 41.378 s]
[INFO] metron-deployment .................................. SUCCESS [ 0.000 s]
[INFO] Metron Ambari Management Pack ...................... SUCCESS [ 0.148 s]
[INFO] metron-docker ...................................... SUCCESS [ 2.782 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:05 min
[INFO] Finished at: 2017-02-26T00:05:34-05:00
[INFO] Final Memory: 112M/2199M
[INFO] ------------------------------------------------------------------------
0:05 ottofowler@Winterfell /Users/ottofowler/src/apache/work/incubator-metron-pr-466
% git status
On branch pr-466
nothing to commit, working tree clean

+1

@asfgit asfgit closed this in 164d602 Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants