This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-742: Generated code for profile window selector DSL did not get committed as part of METRON-690 #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lest we be concerned this implies that the testing done on 690 is voided, this was due to the removal of the
NOW
lexical token, which was unused in the grammar, along with a really dumb refactoring mistake changing "parse" to "processing" that only hit generated code. The unit tests, etc. ran the code in this PR since it was generated as part of the build.This brings me to an interesting question that we might want to discuss. Early on, we decided to submit generated code to ease potential issues around pulling code into IDEs (generated code means we don't have to either remind people to rerun
mvn generate-sources
or to instruct their IDEs to regenerate sources automatically). Maybe we should revisit that point, but I don't know, it's just a thought.