This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-764 DST bug in metron-profiler-client Unit Tests #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Unit Test bug. Please see https://issues.apache.org/jira/browse/METRON-764 for detailed description and how to reproduce the problem.
I only changed a Unit Test file and a docs file, therefore I only tested Unit Tests, which pass as shown by Travis. I also re-ran the reproduction manually and showed it no longer happens with the fix.
=================
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
[NA] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
[NA] Have you written or updated unit tests and or integration tests to verify your changes?
[NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[NA] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes: