Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-764 DST bug in metron-profiler-client Unit Tests #476

Closed
wants to merge 1 commit into from

Conversation

mattf-apache
Copy link
Member

This is a Unit Test bug. Please see https://issues.apache.org/jira/browse/METRON-764 for detailed description and how to reproduce the problem.

I only changed a Unit Test file and a docs file, therefore I only tested Unit Tests, which pass as shown by Travis. I also re-ran the reproduction manually and showed it no longer happens with the fix.

=================
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • [NA] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:

    mvn -q clean integration-test install && build_utils/verify_licenses.sh 
    
  • [NA] Have you written or updated unit tests and or integration tests to verify your changes?

  • [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • [NA] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book?

@cestella
Copy link
Member

+1, great catch @mattf-horton !

@asfgit asfgit closed this in f1435a6 Mar 17, 2017
lucesape pushed a commit to repairnator/repairnator-experiments that referenced this pull request Mar 19, 2017
lucesape pushed a commit to repairnator/repairnator-experiments that referenced this pull request Mar 22, 2017
lucesape pushed a commit to repairnator/repairnator-experiments that referenced this pull request Mar 23, 2017
lucesape pushed a commit to surli/librepair-XP that referenced this pull request Apr 7, 2017
lucesape pushed a commit to surli/librepair-XP that referenced this pull request Apr 7, 2017
lucesape pushed a commit to surli/librepair-XP that referenced this pull request Apr 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants