This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-822 Improve Fastcapa Performance #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The additional commits are showing up as Github is out-of-sync with Apache. That should clear-up once they sync back up. |
cestella
reviewed
Apr 5, 2017
metron-sensors/fastcapa/src/kafka.c
Outdated
| // update queue depth of this kafka connection | ||
| kaf_conn_stats[conn_id].depth = rd_kafka_outq_len(rk); | ||
|
|
||
| // TODO this should be handled by a logging lib that can handle faults and rolling the output file |
There was a problem hiding this comment.
Can we have a JIRA created on this?
There was a problem hiding this comment.
Created METRON-828 to track this.
metron-sensors/fastcapa/src/args.c
Outdated
| printf("[ -b BURST_SIZE ] defined as %d \n", app.burst_size); | ||
|
|
||
| if(app.burst_size < 1 || app.burst_size > MAX_BURST_SIZE) { | ||
| printf("Invalid burst size; burst=%u must be in [1, %u]. \n", app.burst_size, MAX_BURST_SIZE); |
There was a problem hiding this comment.
Actually, same comment on the error comments below.
There was a problem hiding this comment.
Sure, makes sense.
|
As a comment on the JIRA itself, I added some details of a performance test showing the probe operating successfully at ~1.1 Gbps. |
10 tasks
lucesape
pushed a commit
to repairnator/repairnator-experiments
that referenced
this pull request
Apr 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains significant improvements to the performance and scalability of Fastcapa.
This change has been tested on Cisco UCS hardware with a 10G Cisco VNIC. The probe was able to capture 1 gbps before packets started to drop. Additional performance tuning would push this ceiling much higher, but for my purposes, I just needed to reach 1 gbps. Additional work will proceed in the future to find its true performance ceiling.
To test the change yourself, simply spin-up the virtualized test environment which will deploy and validate that Fastcapa can land packets in Kafka correctly.
Pull Request Checklist
For all changes:
For code changes: