Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

mismatch of padding in conv between MXNet and ONNX #10663

Closed
2 tasks
zheng-da opened this issue Apr 24, 2018 · 3 comments
Closed
2 tasks

mismatch of padding in conv between MXNet and ONNX #10663

zheng-da opened this issue Apr 24, 2018 · 3 comments

Comments

@zheng-da
Copy link
Contributor

zheng-da commented Apr 24, 2018

MXNet conv currently assumes a tuple of 2 elements (height, width), while ONNX uses a tuple of 4 elements (left, right, top, bottom). Currently, when MXNet loads a ONNX model, it still uses a padding tuple of 4 elements.

The current implementation of MXNet conv doesn't check the number of elements in the tuple and just uses the first two elements in the tuple. For symmetric padding, this issue is currently ignored by MXNet.

The ideal solution should be:

  • fix the ONNX converter so that it loads the padding correctly, so MXNet always gets a padding tuple with 2 elements.
  • check the parameters of the operators to make sure the inputs are correct.

@ThomasDelteil said there are some potential use cases that might require padding of (left, right, top, bottom).

@eric-haibin-lin @piiswrong @lupesko

@nswamy
Copy link
Member

nswamy commented Apr 24, 2018

@anirudhacharya

@anirudhacharya
Copy link
Member

fix - #10676

@anirudhacharya
Copy link
Member

@zheng-da can you verify and close this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants