Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

test_ndarray.test_cached has fixed seed that can mask flakiness #11708

Closed
szha opened this issue Jul 13, 2018 · 2 comments
Closed

test_ndarray.test_cached has fixed seed that can mask flakiness #11708

szha opened this issue Jul 13, 2018 · 2 comments
Labels
Flaky Test
Projects
Tests Improvement

Comments

@szha
Copy link
Member

szha commented Jul 13, 2018

The unit test in title have been using fixed seed to mask flakiness. Suggested action:

  1. Evaluate whether the test is flaky without fixed seed. If not, remove seed. Else move to 2
  2. If test is flaky, determine whether it's an actual uncaught edge case. If so, fix the operator. Else move to 3
  3. If numerical instability is inevitable, adjust tolerance level appropriately.
@szha szha added this to To Do in Tests Improvement via automation Jul 13, 2018
@haojin2
Copy link
Contributor

haojin2 commented Jul 13, 2018

This test is tracked at #8049 already.

@szha
Copy link
Member Author

szha commented Jul 13, 2018

Closing as a duplicate of #8049

@szha szha closed this as completed Jul 13, 2018
Tests Improvement automation moved this from To Do to Done Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Flaky Test
Projects
Tests Improvement
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szha @haojin2