This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

test_operator.test_bilinear_sampler has fixed seed that can mask flakiness #11711

Closed

szha opened this issue Jul 13, 2018 · 1 comment

Labels

Projects

Tests Improvement

Member

szha commented Jul 13, 2018

The unit test in title have been using fixed seed to mask flakiness. Suggested action:

Evaluate whether the test is flaky without fixed seed. If not, remove seed. Else move to 2
If test is flaky, determine whether it's an actual uncaught edge case. If so, fix the operator. Else move to 3
If numerical instability is inevitable, adjust tolerance level appropriately.

szha added Test Flaky labels

szha added this to To Do in Tests Improvement via automation

Contributor

apeforest commented Jul 13, 2018

Thannks for filing this issue. We will investigate this Flaky test

haojin2 mentioned this issue

Re-enable randomized test_bilinear_sampler #12227

Merged

5 tasks

sandeep-krishnamurthy closed this as completed

Tests Improvement automation moved this from To Do to Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.