Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Feature Request] Implementation of L-BFGS optimizer #12132

Open
jasonyu1996 opened this issue Aug 11, 2018 · 5 comments
Open

[Feature Request] Implementation of L-BFGS optimizer #12132

jasonyu1996 opened this issue Aug 11, 2018 · 5 comments

Comments

@jasonyu1996
Copy link
Contributor

Hi!
Would the developers consider adding an implementation of limited memory BFGS to the library? PyTorch offers one here: https://pytorch.org/docs/stable/optim.html?#torch.optim.LBFGS

@adaaaaaa
Copy link

follow with interest...

@lanking520
Copy link
Member

@jasonyu1996 thanks for your question and keep watching this thread.
@eric-haibin-lin do we have something similar in MXNet?

@mxnet-label-bot please label this as [feature, memory]

@anirudhacharya
Copy link
Member

anirudhacharya commented Aug 13, 2018

MXNet does not have this optimizer( see here), and optimizer requests are tracked here - #9182

@jasonyu1996
Copy link
Contributor Author

Thanks! I have added it to the optimizer request list. Actually I am quite willing to see if I could implement one for MXNet myself.

@haojin2
Copy link
Contributor

haojin2 commented Aug 18, 2018

@jasonyu1996 You're more than welcome to add this thing yourself if you want to, most of the optimizers should be here: https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/optimizer.py. You can use any of them (for example, SGD) as reference to implement this. And all unit tests for optimizers are here: https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_optimizer.py. Please make sure to add a test for your new optimizer once you finish implementing it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants