Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Arg name inconsistencies #15735

Closed
ChaiBapchya opened this issue Aug 2, 2019 · 2 comments · Fixed by #15761
Closed

Arg name inconsistencies #15735

ChaiBapchya opened this issue Aug 2, 2019 · 2 comments · Fixed by #15761
Labels

Comments

@ChaiBapchya
Copy link
Contributor

Operators like concat, Elementwise_sum, add_n, squeeze, stack etc have one of their parameters as *args (variable argument) and specifically the arg_type is NDArray-or-Symbol[] (notice it is a list of NDArray or Symbol)

However, the arg_name for such arg_type is different for different functions

'arg_name': 'args', 'arg_type': 'NDArray-or-Symbol[]'

  1. khatri_rao
    'khatri_rao': {'has_backward': False, 'nd_op_handle': <function khatri_rao at 0x122548ae8>, 'params': {'narg': 1, 'arg_names': ['args'], 'arg_types': ['NDArray-or-Symbol[]']}}
  2. Elementwise_sum
    'ElementWiseSum': {'has_backward': False, 'nd_op_handle': <function ElementWiseSum at 0x122455950>, 'params': {'narg': 1, 'arg_names': ['args'], 'arg_types': ['NDArray-or-Symbol[]']}}
  3. add_n
    'add_n': {'has_backward': False, 'nd_op_handle': <function add_n at 0x122533488>, 'params': {'narg': 1, 'arg_names': ['args'], 'arg_types': ['NDArray-or-Symbol[]']}}

'arg_name': 'data', 'arg_type': 'NDArray-or-Symbol[]'
while for other operators
squeeze, concat, stack, etc

Note - 3 ops that have arg_name as args have just 1 argument
Rest ops that have arg_name as data have multiple arguments

Is this a case of inconsistency? Should they all be referred as data instead of generic args?

@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Bug, Feature

@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [Question, Operator]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants