Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

typo in CmakeLists.txt about OPENMP_FOUND #17579

Closed
sl1pkn07 opened this issue Feb 12, 2020 · 6 comments
Closed

typo in CmakeLists.txt about OPENMP_FOUND #17579

sl1pkn07 opened this issue Feb 12, 2020 · 6 comments

Comments

@sl1pkn07
Copy link
Contributor

https://github.com/apache/incubator-mxnet/blob/f0d1d9dd8879920c68290b6f520f97a17444354c/CMakeLists.txt#L420

according cmake documentation, OPENMP_FOUND should be OpenMP_FOUND

https://cmake.org/cmake/help/git-master/module/FindOpenMP.html

greetings
@sl1pkn07 sl1pkn07 added the Bug label Feb 12, 2020
@szha
Copy link
Member

szha commented Feb 12, 2020

Thanks for bringing this up. Would you be open to contributing a patch to fix it?

sl1pkn07 added a commit to sl1pkn07/incubator-mxnet that referenced this issue Feb 12, 2020
@sl1pkn07
fix apache#17579
e1f40b0
@sl1pkn07 sl1pkn07 mentioned this issue Feb 12, 2020
Closed
@sl1pkn07
Copy link
Contributor Author

@szha done

@leezu
Copy link
Contributor

leezu commented Feb 12, 2020 •
edited

Variables are case insensitive in CMake syntax. This is only an optical issue.

@sl1pkn07
Copy link
Contributor Author

sl1pkn07 commented Feb 12, 2020 •
edited

not at all, a example

Nadrin/Quartz#2 (the first part)

@leezu
Copy link
Contributor

leezu commented Feb 13, 2020

Ok. I'm not sure why this worked so far then.

@leezu
Copy link
Contributor

leezu commented Feb 13, 2020

OPENMP_FOUND is also supported variable.

https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/FindOpenMP.cmake#L584

@szha szha removed the Bug label May 23, 2020
@szha szha closed this as completed May 23, 2020
@ruevs ruevs mentioned this issue Dec 9, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #17579 sl1pkn07/incubator-mxnet
3 participants
@sl1pkn07 @leezu @szha