Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Doc/Test Fix] Fix documentation of embedding layer + Fix LayerNorm Test #10136

Merged
merged 8 commits into from Mar 17, 2018

Conversation

sxjscience
Copy link
Member

@sxjscience sxjscience commented Mar 16, 2018

Description

  1. Fix the doc. Embedding layer supports (N-1)-D array to N-D array. This makes it consistent with the doc in Symbol/NDArray http://mxnet.incubator.apache.org/api/python/ndarray/ndarray.html#mxnet.ndarray.Embedding
  2. Fix flaky layer_norm test, fixes Flaky test test_operator.test_layer_norm #10114

@sxjscience sxjscience requested a review from szha as a code owner March 16, 2018 18:55
@sxjscience sxjscience changed the title Fix documentation of embedding layer Fix documentation of embedding layer + Fix fix LayerNorm Test Mar 16, 2018
@marcoabreu
Copy link
Contributor

Was there an issue for this test failure? Then we could tick one off :)

@sxjscience
Copy link
Member Author

sxjscience commented Mar 17, 2018 via email

@sxjscience sxjscience changed the title Fix documentation of embedding layer + Fix fix LayerNorm Test [Small Fix] Fix documentation of embedding layer + Fix fix LayerNorm Test Mar 17, 2018
@sxjscience sxjscience changed the title [Small Fix] Fix documentation of embedding layer + Fix fix LayerNorm Test [Doc/Test Fix] Fix documentation of embedding layer + Fix fix LayerNorm Test Mar 17, 2018
@sxjscience sxjscience changed the title [Doc/Test Fix] Fix documentation of embedding layer + Fix fix LayerNorm Test [Doc/Test Fix] Fix documentation of embedding layer + Fix LayerNorm Test Mar 17, 2018
@szha szha merged commit 67af47c into apache:master Mar 17, 2018
ashokei pushed a commit to ashokei/incubator-mxnet that referenced this pull request Mar 27, 2018
…est (apache#10136)

* fix documentation of embedding layer

* try to fix

* fix

* try to fix

* try to fix

* try to fix

* update

* try to fix
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
…est (apache#10136)

* fix documentation of embedding layer

* try to fix

* fix

* try to fix

* try to fix

* try to fix

* update

* try to fix
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
…est (apache#10136)

* fix documentation of embedding layer

* try to fix

* fix

* try to fix

* try to fix

* try to fix

* update

* try to fix
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
…est (apache#10136)

* fix documentation of embedding layer

* try to fix

* fix

* try to fix

* try to fix

* try to fix

* update

* try to fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test test_operator.test_layer_norm
3 participants