This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-212] [R] Fix Random Samplers from Uniform and Gaussian distribution in R bindings #10450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudhacharya
changed the title
hetong007
suggested changes
Apr 7, 2018
hetong007
suggested changes
Apr 9, 2018
hetong007
approved these changes
Apr 9, 2018
|
@hetong007 can you please merge this PR. |
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
…ution in R bindings (apache#10450) * fix random samplers-uniform and gaussian * add tests for gaussian and uniform distributions * fix precision issues that may cause flakiness.
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…ution in R bindings (apache#10450) * fix random samplers-uniform and gaussian * add tests for gaussian and uniform distributions * fix precision issues that may cause flakiness.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sampling from uniform and normal distribution is currently broken in mxnet's R bindings. Check this issue - #9804 (comment), I have given the root cause of the bug in the comments.
This code was working in mxnet v0.10 but is currently broken in mxnet version >= v 1.10.
The change that broke the samplers was introduced in this PR - https://github.com/apache/incubator-mxnet/pull/3334/files#diff-69861896bcb94074f59474beba4e4b90
Marking @tqchen and @piiswrong who were on the above PR so that they can weigh in their thoughts about this change.
@hetong007