This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-319] [WIP] Add Autocomplete Macros in Scala #10546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roshrini
suggested changes
Apr 13, 2018
| import scala.collection.mutable.{HashMap, ListBuffer} | ||
| import org.apache.mxnet.init.Base._ | ||
|
|
||
|
|
There was a problem hiding this comment.
Add comments explaining the functionality of this macro
| } | ||
| // scalastyle:off | ||
| val defaultConfig = s"(name : scala.Predef.String, attr : scala.Predef.Map[scala.Predef.String, scala.Predef.String])(args : org.apache.mxnet.Symbol*)(kwargs : scala.Predef.Map[scala.Predef.String, scala.Any]) : org.apache.mxnet.Symbol" | ||
| // s"/**\n${desc.mkString("\n")}\n${params.mkString("\n")}\n* @return $returnType\n*/\ndef $functionName(${traitsec.mkString(", ")}) : Any" |
| typeConv = typeMap(commaRemoved(0)) | ||
| } | ||
| // if (!typeMap.contains(commaRemoved(0))) { | ||
| // logger.error("First Field not recognized " + commaRemoved(0)) |
|
Tested with |
nswamy
changed the title
|
Close this PR since it is outdated and duplicated with the new one: #10991 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SymbolBaseMacros File: It will generate a SymbolBase trait with full documentation on the Symbol APIs. Also enable the "return_type" Parameters that will be helpful to generate the docs.
@nswamy @yzhliu @Roshrini
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes