This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-329] support SparseEmbedding with dense weight #10585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2018 05:38
eric-haibin-lin
changed the title
|
@ZiyueHuang @haojin2 could you review? |
haojin2
reviewed
Apr 18, 2018
| @@ -1638,10 +1638,10 @@ def check_sparse_elementwise_sum_with_shape(stype, shape, n): | |||
| @with_seed() | |||
| def test_sparse_embedding(): | |||
| ''' test sparse embedding operator ''' | |||
| def check_sparse_embedding(in_dim, out_dim, batch, densities, deterministic): | |||
| def check_sparse_embedding(in_dim, out_dim, batch, densities, deterministic, weight_stype): | |||
There was a problem hiding this comment.
What about change the name to "check_deterministic"? "deterministic" does not sound really straightforward.
There was a problem hiding this comment.
deterministic is the param passed to mx.sym.contrib.SparseEmbedding. See line 1645
|
LGTM |
ZiyueHuang
approved these changes
Apr 19, 2018
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* add sparseembedding(dense_weight) * update test * Update test_sparse_operator.py
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* add sparseembedding(dense_weight) * update test * Update test_sparse_operator.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow dense weight in SparseEmbedding op. I'll also add support for sgd(dense_weight, sparse_grad) later.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments