This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
make the slice of sequential a sequential #10630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiswrong
reviewed
Apr 20, 2018
| layers = list(self._children.values())[key] | ||
| if isinstance(layers, list): | ||
| with self.name_scope(): | ||
| net = type(self)() |
There was a problem hiding this comment.
why type(self)? There is no guarantee that type(self)'s constructor accepts no arguments
There was a problem hiding this comment.
This is so that any blocks that inherit sequential blocks have this default implementation. Child class that have other arguments can choose to override this.
piiswrong
reviewed
Apr 20, 2018
| return list(self._children.values())[key] | ||
| layers = list(self._children.values())[key] | ||
| if isinstance(layers, list): | ||
| with self.name_scope(): |
There was a problem hiding this comment.
would it better to set prefix directly to be the same as self instead of using name_scope?
There was a problem hiding this comment.
hmm, good point. this way we can get rid of one namescope
|
Found a minor bug in using _brief_print_list. in py3, dict.keys() doesn't return a list. https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/gluon/parameter.py#L779 |
cjolivier01
pushed a commit
to cjolivier01/mxnet
that referenced
this pull request
Apr 27, 2018
* make the slice of sequential a sequential * update per comment * py3 compat
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* make the slice of sequential a sequential * update per comment * py3 compat
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* make the slice of sequential a sequential * update per comment * py3 compat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make the slice of sequential a sequential
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments