Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-355] fix race condition in csr cast_storage block kernel #10643

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Apr 22, 2018

Description

It looks like the access to block_nnz has some race condition and fails on the test case I added (once per 10 runs)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin changed the title [WIP] fix race condition in csr cast_storage block kernel [MXNET-355] fix race condition in csr cast_storage block kernel Apr 22, 2018
@eric-haibin-lin
Copy link
Member Author

@haojin2 @reminisce

@haojin2
Copy link
Contributor

haojin2 commented Apr 22, 2018

LGTM!

@eric-haibin-lin eric-haibin-lin merged commit 274fae8 into apache:master Apr 24, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Apr 27, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Apr 27, 2018
@anirudh2290 anirudh2290 mentioned this pull request Apr 27, 2018
7 tasks
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@eric-haibin-lin eric-haibin-lin deleted the cast_storage branch September 2, 2019 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants