This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Revert "[MXNET-367] update mkldnn to v0.14 and disable building test examples" #10808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cpp tests are still not enabled? I think that PR can be intercepted by mkldnn cpp tests. |
|
The problem here is that there were only 10 hours in between the merges of the two clashing PRs (see the email on dev@ for details). It's hard to avoid that without causing too much inconvenience. |
|
Hah, I see. You are right, it's hard to avoid that. But we still can set a last build time constraint to reduce risk of that. |
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 7, 2018
…examples (apache#10736)" (apache#10808) This reverts commit 3c7afcc.
jinhuang415
pushed a commit
to jinhuang415/incubator-mxnet
that referenced
this pull request
May 29, 2018
…examples (apache#10736)" (apache#10808) This reverts commit 3c7afcc.
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
…examples (apache#10736)" (apache#10808) This reverts commit 3c7afcc.
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…examples (apache#10736)" (apache#10808) This reverts commit 3c7afcc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10736
This PR breaks master
@pengzhao-intel @TaoLv @ashokei @zheng-da