This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Sparse-Gluon] embedding with sparse grad #10924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szha
reviewed
May 15, 2018
| arg_arrays = {} | ||
| contains_sparse = False | ||
| for param in self._params: | ||
| arg_arrays[param.name] = param.data(self._contexts[0]) |
There was a problem hiding this comment.
did you try to do step on parameter with deferred initialization? what message did you get?
There was a problem hiding this comment.
Yes I tried the language model example. param.data() was called in the previous implementation (line 113)
szha
reviewed
May 15, 2018
| if param._grad_stype != 'default': | ||
| contains_sparse = True | ||
| # update_on_kvstore is set to False by the user | ||
| if self._update_on_kvstore is False: |
There was a problem hiding this comment.
if self._update_on_kvstore is None, I don't need to throw the err
szha
approved these changes
May 15, 2018
eric-haibin-lin
changed the title
piiswrong
reviewed
May 15, 2018
python/mxnet/gluon/parameter.py
Outdated
| @@ -114,6 +116,11 @@ def __init__(self, name, grad_req='write', shape=None, dtype=mx_real_t, | |||
| self.wd_mult = wd_mult | |||
| self.grad_req = grad_req | |||
| self.init = init | |||
| grad_stype = 'default' if grad_stype is None else grad_stype | |||
There was a problem hiding this comment.
why not use 'default' as argument default value
piiswrong
reviewed
May 15, 2018
python/mxnet/gluon/trainer.py
Outdated
| contains_sparse = True | ||
| # update_on_kvstore is set to False by the user | ||
| if self._update_on_kvstore is False: | ||
| raise RuntimeError("Cannot set update_on_kvstore when sparse gradients " |
There was a problem hiding this comment.
include parameter name in message
piiswrong
reviewed
May 15, 2018
| @@ -390,13 +390,14 @@ class Embedding(HybridBlock): | |||
| - **out**: N-D tensor with shape: `(x1, x2, ..., xN-1, output_dim)`. | |||
| """ | |||
| def __init__(self, input_dim, output_dim, dtype='float32', | |||
| weight_initializer=None, **kwargs): | |||
| weight_initializer=None, sparse_grad=False, **kwargs): | |||
There was a problem hiding this comment.
documentation for argument
jinhuang415
pushed a commit
to jinhuang415/incubator-mxnet
that referenced
this pull request
May 29, 2018
* draft * updat test * fix kvstore * fix lint * fix test * add proper error msg * CR comment
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* draft * updat test * fix kvstore * fix lint * fix test * add proper error msg * CR comment
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* draft * updat test * fix kvstore * fix lint * fix test * add proper error msg * CR comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add sparse_grad option to hybrid embedding block. This block doesn't have optimizations for distributed training.
Manually checked word_language_model example with sparse_grad=True (without grad clipping). The result is exactly the same as the original implementation.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments