Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-307] Fix flaky tutorial tests from CI #10956

Merged
merged 14 commits into from May 17, 2018
Merged

[MXNET-307] Fix flaky tutorial tests from CI #10956

merged 14 commits into from May 17, 2018

Conversation

ThomasDelteil
Copy link
Contributor

@ThomasDelteil ThomasDelteil commented May 15, 2018 •
edited

Description

  • Move tutorials to smaller models in order to limit issues in CI
  • Add small delay between tests to allow socket to be cleared
  • Re-add the pre-trained model tutorial that was removed by mistake on redesign

see issues:

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@ThomasDelteil ThomasDelteil requested a review from szha as a code owner May 15, 2018 20:52
@ThomasDelteil ThomasDelteil changed the title [WIP][MXNET-307] [WIP][MXNET-307] Fix flaky tests from CI May 15, 2018
@ThomasDelteil ThomasDelteil changed the title [WIP][MXNET-307] Fix flaky tests from CI [WIP][MXNET-307] Fix flaky tutorial tests from CI May 15, 2018
@szha szha added this to To Do in Tests Improvement via automation May 15, 2018
@ThomasDelteil ThomasDelteil changed the title [WIP][MXNET-307] Fix flaky tutorial tests from CI [MXNET-307] Fix flaky tutorial tests from CI May 16, 2018
indhub
indhub reviewed May 16, 2018
View reviewed changes
docs/tutorials/python/predict_image.md Outdated
pre-trained model contains two parts, a json file containing the model
definition and a binary file containing the parameters. In addition, there may be
a text file for the labels.
We first download a pre-trained ResNet 18 layer that is trained on the ImageNet dataset with over 1 million images and one thousand classes. A pre-trained model contains two parts, a json file containing the model definition and a binary file containing the parameters. In addition, there may be a `synset.txt` text file for the labels.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'ResNet 18 model' or 'ResNet 18 layer model'

@indhub indhub merged commit c4144f2 into apache:master May 17, 2018
Tests Improvement automation moved this from To Do to Done May 17, 2018
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request May 29, 2018
@ThomasDelteil
[MXNET-307] Fix flaky tutorial tests from CI (apache#10956)
1467062 
* re-add the predict image tutorial

* Update predict_image.md

* switching to GoogleNet to have a smaller model

* Update inference_on_onnx_model.md

* Update inference_on_onnx_model.md

* Update test_tutorials.py

* Update test_tutorials.py

* Update inference_on_onnx_model.md

* trigger build

* Trigger build

* trigger build

* Trigger build

* update according to review
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@ThomasDelteil @indhub
[MXNET-307] Fix flaky tutorial tests from CI (apache#10956)
f70f766 
* re-add the predict image tutorial

* Update predict_image.md

* switching to GoogleNet to have a smaller model

* Update inference_on_onnx_model.md

* Update inference_on_onnx_model.md

* Update test_tutorials.py

* Update test_tutorials.py

* Update inference_on_onnx_model.md

* trigger build

* Trigger build

* trigger build

* Trigger build

* update according to review
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@ThomasDelteil @zheng-da
[MXNET-307] Fix flaky tutorial tests from CI (apache#10956)
118878d 
* re-add the predict image tutorial

* Update predict_image.md

* switching to GoogleNet to have a smaller model

* Update inference_on_onnx_model.md

* Update inference_on_onnx_model.md

* Update test_tutorials.py

* Update test_tutorials.py

* Update inference_on_onnx_model.md

* trigger build

* Trigger build

* trigger build

* Trigger build

* update according to review
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@indhub indhub indhub left review comments

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Tests Improvement
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThomasDelteil @indhub