This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-521] Add Facebook open-graph tag integration #11155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomelane @ThomasDelteil - any thoughts on this? Sharing should be better... I made the image according to the minimum requirements FB suggests. Here's the debug console... it shows the new image: Much better than what is there now!: |
|
@szha Can you please merge this? |
|
Yes, looks great! |
|
@eric-haibin-lin @szha Bueller? Can you please merge this? |
|
|
|
@anirudh2290 @indhub could one of you merge this please? |
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* Adding the first set of Facebook OG tags to layout.html * Adding the direct link to the Facebook OG image * Re-arranging the og description tag * Changes to fix merge conflicts * Adding secure_url to the og:image tag * Adding the redundant og:image tag
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* Adding the first set of Facebook OG tags to layout.html * Adding the direct link to the Facebook OG image * Re-arranging the og description tag * Changes to fix merge conflicts * Adding secure_url to the og:image tag * Adding the redundant og:image tag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Facebook Open-Graph tags
Checklist
Changes