Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-543] disable scalatest on Spark #11264

Merged
merged 3 commits into from Jun 14, 2018

Conversation

lanking520
Copy link
Member

Description

This is aimed to fix this issue
@CodingCat @nswamy @yzhliu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 requested a review from yzhliu as a code owner June 13, 2018 20:10
@lanking520
Copy link
Member Author

@CodingCat I will focus more on which test that breaks the CI and see if we can find an alternative rather than kill them all

@CodingCat
Copy link
Contributor

when you disable the test, would you please only disable https://github.com/apache/incubator-mxnet/pull/10462/files#diff-b9835287795c57e48fb9da87d39d06a8R64 (LeNet) for now (I believe LeNet is much more memory-intensive ) and leave MLP to guard the correctness in Spark side,

if MLP also behaves flaky, let's go ahead and kill it (I think it will not)

@lanking520
Copy link
Member Author

@CodingCat It also breaks scalatest on Mac, may not be only the memory issues

@CodingCat
Copy link
Contributor

it happens consistently in mac?

@lanking520 lanking520 changed the title [MXNET-543] disable scalatest on Spark [MXNET-543][DO NOT MERGE] disable scalatest on Spark Jun 13, 2018
@lanking520
Copy link
Member Author

lanking520 commented Jun 13, 2018

Please Don't merge at this time, still WIP
Finish fixing... have my hand crossed to pass the test

@lanking520 lanking520 changed the title [MXNET-543][DO NOT MERGE] disable scalatest on Spark [MXNET-543] disable scalatest on Spark Jun 13, 2018
}
// test("run spark with MLP") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to comment we can just remove, but not blocking it as this will have to go through another round of CI.

@anirudh2290 anirudh2290 merged commit eb95d7b into apache:master Jun 14, 2018
@lanking520 lanking520 deleted the flaky-fixer branch June 14, 2018 16:58
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* disable scalatest on Spark

* Kill the entire build

* Disable test in test folder and add dummy label
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
* disable scalatest on Spark

* Kill the entire build

* Disable test in test folder and add dummy label
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants