Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-565]change wget into java download #11383

Merged
merged 5 commits into from Jul 3, 2018
Merged

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Jun 25, 2018

Description

This is a PR to use Apache FileUtils kit to replace the existing wget method. This will help future Windows support on the Scala test and help customer to run scalatest when there are no internet connection.
@marcoabreu @yzhliu @nswamy

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 requested a review from yzhliu as a code owner June 25, 2018 04:24
"https://s3.amazonaws.com/model-server/inputs/Pug-Cookie.jpg " +
"-P " + tempDirPath + "/inputImages/") !
var tmpFile = new File(tempDirPath + "/resnet18/resnet-18-symbol.json")
if (!tmpFile.exists()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past, we had problems with corrupt files being downloaded, so this check could cause problems. What do you think about moving this into a helper function which has this logic as well as hash-validation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoabreu good point, we'll take this into consideration in our next PR.

@marcoabreu
Copy link
Contributor

Great effort towards getting Scala working on Windows!

@nswamy nswamy merged commit 01f1457 into apache:master Jul 3, 2018
@lanking520 lanking520 deleted the wget-fixer branch July 5, 2018 16:15
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants